Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #8960 #9845

Conversation

wenjiaswe
Copy link
Contributor

Cherry pick of #8960 on release-3.2.

#8960: metrics: Add server_version metric

@gyuho
Copy link
Contributor

gyuho commented Jun 13, 2018

Can we also update https://github.com/coreos/etcd/blob/master/CHANGELOG-3.2.md

### Metrics, Monitoring

- Add [`etcd_server_version`](https://github.com/coreos/etcd/pull/8960) Prometheus metric.
  - To replace [Kubernetes `etcd-version-monitor`](https://github.com/coreos/etcd/issues/8948).

Thanks!

wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Jun 13, 2018
@wenjiaswe
Copy link
Contributor Author

@gyuho I juste opened a PR to update CHANGELOG-3.2 and am in the process of backporting #8960 to release-3.1 as well. Thanks!

@gyuho gyuho merged commit 5e6adfa into etcd-io:release-3.2 Jun 13, 2018
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Jun 13, 2018
gyuho added a commit that referenced this pull request Jun 13, 2018
@wenjiaswe wenjiaswe deleted the automated-cherry-pick-of-#8960-upstream-release-3.2 branch October 15, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants